Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Typelevel ecosystem broken links fix #4005

Merged
merged 31 commits into from
Oct 3, 2021

Conversation

benkio
Copy link
Contributor

@benkio benkio commented Oct 2, 2021

related to the issue #4004

  • Fix the 404 links
  • Avoid redirections
  • Add Fly4s
  • upgrade shell.nix to the latest 21.05

links checked with https://validator.w3.org/checklink against the page https://typelevel.org/cats/typelevelEcosystem.html

I wasn't able to check it locally yet, having problems in generating the microsite, but this is up for visibility as draft
As soon as I solve the problems with the microsite generations I wish to test it following this article: https://matthewsetter.com/writing-tools/npm-broken-link-checker/

Cheers

@benkio
Copy link
Contributor Author

benkio commented Oct 2, 2021

this is what I see after moving to the branch and launching

nix-shell --pure
sbt docs/makeMicrosite

https://pastebin.com/u8DCNGHD

@rossabaker
Copy link
Member

Thanks!

In a hurry now, but I think the microsite does not compile on the default scala version of the rest of the build. The ci.yml or old build runs should make clear which version works.

Now it picks up the right version of Jekyll + ruby and the microsite
is correctly generated. With 2.12.4 as per ci.yml
@benkio
Copy link
Contributor Author

benkio commented Oct 3, 2021

looking at ci.ymlI was able to generate the microsite, but only after upgrading nixpkgs to the last version in order to have access to later jekyll and ruby. I think we can move forward from the 18.09 release.

I runned linkchecker and this is the result of 5 min scanning

@benkio benkio marked this pull request as ready for review October 3, 2021 00:33
rossabaker
rossabaker previously approved these changes Oct 3, 2021
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Markdown references could be used to DRY up FS2 or other repeated links, but it's not really that big a deal.

@benkio
Copy link
Contributor Author

benkio commented Oct 3, 2021

Nice work!

Markdown references could be used to DRY up FS2 or other repeated links, but it's not really that big a deal.

Just added the link references for duplicated links

@rossabaker rossabaker merged commit 7f2611c into typelevel:main Oct 3, 2021
@benkio benkio deleted the typelevelEcosystemBrokenLinksFix branch October 3, 2021 14:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants