Added discipline tests for the new Traverse laws
#4283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
changed the title
Traverse laws
armanbilge
approved these changes
Aug 17, 2022
Comment on lines
85
to
+92
| "traverse ref mapAccumulate" -> forAll(laws.mapAccumulateRef[M, A, C] _), | ||
| "traverse ref mapWithIndex" -> forAll(laws.mapWithIndexRef[A, C] _), | ||
| "traverse ref traverseWithIndexM" -> forAll(laws.traverseWithIndexMRef[Option, A, C] _), | ||
| "traverse ref zipWithIndex" -> forAll(laws.zipWithIndexRef[A, C] _) | ||
| "traverse ref zipWithIndex" -> forAll(laws.zipWithIndexRef[A, C] _), | ||
| "traverse ref zipWithLongIndex" -> forAll(laws.zipWithLongIndexRef[A, C] _), | ||
| "traverse ref mapWithLongIndex" -> forAll(laws.mapWithLongIndexRef[A, C] _), | ||
| "traverse ref traverseWithLongIndexM" -> forAll(laws.traverseWithLongIndexMRef[Option, A, C] _), | ||
| "traverse ref updated" -> forAll(laws.updatedRef[A, A](_, _, _)) |
There was a problem hiding this comment.
Huh, the naming of these law tests seems to be inconsistent in Cats 🤔
cats/laws/src/main/scala/cats/laws/discipline/FoldableTests.scala
Lines 60 to 67 in 83ad02b
danicheg
approved these changes
Aug 17, 2022
johnynek
approved these changes
Aug 17, 2022
|
the boilerplate here has always annoyed me. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added laws tests for methods added in #4248 and #4245. @armanbilge can you take a look?