Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move NonEmptyReducible into its own file #4398

Merged

Conversation

fabianhjr
Copy link
Contributor

This is a small refactor to get my feet in the water of contributing to typelevel. (Checking out mima and other things to attempt some scala 3 stuff later on)

While toying with NonEmptyList noticed that NonEmptyReducible was in the Reducible file and decided to split it to its own file along NonEmptyAlternative and NonEmptyTraverse

No further changes to the source were made.

@armanbilge armanbilge added the behind-the-scenes appreciated, but not user-facing label Feb 18, 2023
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@armanbilge armanbilge changed the title [core/refactor] Split NonEmptyReducible from Reducible Move NonEmptyReducible into its own file Feb 18, 2023
@johnynek
Copy link
Contributor

Thanks! This makes it easy to work with the code in many contexts (e.g. finding links on GitHub).

@armanbilge armanbilge merged commit 5bc20f9 into typelevel:main Feb 18, 2023
@fabianhjr fabianhjr deleted the splitoff-NonEmptyReducible branch February 18, 2023 18:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
behind-the-scenes appreciated, but not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants