Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a different encoding of #4362 (note, which is not yet released). /cc @bpholt
Specifically, Cats has a precedent of offering various
compose
methods for creating nested instances, but I'm not sure if there is much precedent for offering these instances asimplicit
s. Furthermore as noted in #4362 inference does not work very well for this implicit anyway.So I think replacing the implicit with a
composeBifunctor
method may yield better and more consistent ergonomics i.e. Instead of:now you would write:
Thoughts?