Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add Foldable.toStreaming #533

Merged
merged 1 commit into from
Sep 15, 2015
Merged

Add Foldable.toStreaming #533

merged 1 commit into from
Sep 15, 2015

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Sep 15, 2015

No description provided.

@non
Copy link
Contributor

non commented Sep 15, 2015

👍

In some sense being able to (correctly) support this was one of the over-arching goals of the design of Eval, foldRight, and Streaming so I'm glad you put it all together.

@codecov-io
Copy link

Current coverage is 65.16%

Merging #533 into master will increase coverage by +0.07% as of 3c85542

@@            master    #533   diff @@
======================================
  Files          156     156       
  Stmts         2418    2423     +5
  Branches        68      68       
  Methods          0       0       
======================================
+ Hit           1574    1579     +5
  Partial          0       0       
  Missed         844     844

Review entire Coverage Diff as of 3c85542

Powered by Codecov. Updated on successful CI builds.

adelbertc
adelbertc reviewed Sep 15, 2015
View reviewed changes
core/src/main/scala/cats/Foldable.scala
def toStreaming[A](fa: F[A]): Streaming[A] =
foldRight(fa, Now(Streaming.empty[A])){ (a, ls) =>
Now(Streaming.cons(a, ls))
}.value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@adelbertc
Copy link
Contributor

👍

adelbertc added a commit that referenced this pull request Sep 15, 2015
@adelbertc
Merge pull request #533 from ceedubs/foldable-toStreaming
e792851 
Add Foldable.toStreaming
@adelbertc adelbertc merged commit e792851 into typelevel:master Sep 15, 2015
@ceedubs ceedubs deleted the foldable-toStreaming branch September 15, 2015 23:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ceedubs @non @codecov-io @adelbertc @fthomas