Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix monoid zeros for Float/Double #547

Merged
merged 1 commit into from
Sep 28, 2015
Merged

Fix monoid zeros for Float/Double #547

merged 1 commit into from
Sep 28, 2015

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Sep 28, 2015

Fixes #301.

This was ignored for far too long (even though there was #301 for it).
We should really have test coverage on this. I say we merge this for now
but discuss whether this should just be coming from algebra and add
tests to whichever project it comes from.

Fix monoid zeros for Float/Double
6bbe582 
Fixes typelevel#301.

This was ignored for far too long (even though there was typelevel#301 for it).
We should really have test coverage on this. I say we merge this for now
but discuss whether this should just be coming from algebra and add
tests to whichever project it comes from.
@fthomas
Copy link
Member

fthomas commented Sep 28, 2015

👍

1 similar comment
@non
Copy link
Contributor

non commented Sep 28, 2015

👍

@codecov-io
Copy link

Current coverage is 75.48%

Merging #547 into master will not affect coverage as of f43deeb

@@            master    #547   diff @@
======================================
  Files          153     153       
  Stmts         2064    2064       
  Branches        68      68       
  Methods          0       0       
======================================
  Hit           1558    1558       
  Partial          0       0       
  Missed         506     506

Review entire Coverage Diff as of f43deeb

Powered by Codecov. Updated on successful CI builds.

non added a commit that referenced this pull request Sep 28, 2015
@non
Merge pull request #547 from ceedubs/fix-float
5b45c9e 
Fix monoid zeros for Float/Double
@non non merged commit 5b45c9e into typelevel:master Sep 28, 2015
@non non removed the in progress label Sep 28, 2015
@ceedubs ceedubs deleted the fix-float branch September 28, 2015 12:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ceedubs @fthomas @non @codecov-io