Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add FreeApplicative.analyze #572

Merged
merged 1 commit into from
Oct 16, 2015

Conversation

smungee
Copy link
Contributor

@smungee smungee commented Oct 15, 2015

In trying to port the FreeApplicative example from @jdegoes's ScalaWorld
2015 talk[1] to cats, I found that cats does not have a
FreeApplicative.analyze method, which allows us to compile a
FreeApplicative into a monoid.

This commit adds FreeApplicative.analyze, as well as a new test for
this, as per a discussion on gitter [2].

[1] https://github.com/jdegoes/scalaworld-2015/blob/master/src/main/scala/asmfree.scala#L32
[2] https://gitter.im/non/cats?at=561ed5373a0d354869528194

In trying to port the FreeApplicative example from @jdegoes's ScalaWorld
2015 talk[1] to cats, I found that cats does not have a
FreeApplicative.analyze method, which allows us to compile a
FreeApplicative into a monoid.

This commit adds FreeApplicative.analyze, as well as a new test for
this, as per a discussion on gitter [2].

[1] https://github.com/jdegoes/scalaworld-2015/blob/master/src/main/scala/asmfree.scala#L32
[2] https://gitter.im/non/cats?at=561ed5373a0d354869528194
@codecov-io
Copy link

Current coverage is 75.71%

Merging #572 into master will increase coverage by +0.03% as of 6e2c3d5

@@            master    #572   diff @@
======================================
  Files          157     157       
  Stmts         2163    2166     +3
  Branches        68      68       
  Methods          0       0       
======================================
+ Hit           1637    1640     +3
  Partial          0       0       
  Missed         526     526       

Review entire Coverage Diff as of 6e2c3d5

Powered by Codecov. Updated on successful CI builds.

@adelbertc
Copy link
Contributor

👍

1 similar comment
@non
Copy link
Contributor

non commented Oct 16, 2015

👍

non added a commit that referenced this pull request Oct 16, 2015
@non non merged commit 87c3fb3 into typelevel:master Oct 16, 2015
@non
Copy link
Contributor

non commented Oct 16, 2015

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants