Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bugfix/queue get #1308

Merged
merged 6 commits into from
Nov 6, 2018
Merged

Bugfix/queue get #1308

merged 6 commits into from
Nov 6, 2018

Conversation

pchlupacek
Copy link
Contributor

Fixes #1293.

Needs to be squashed before merge.

@pchlupacek
Copy link
Contributor Author

huh travis complains about bincompat? All I have touched is private, so this seems odd :-(

@mpilquist
Copy link
Member

We can add an exclusion for the Travis error.

Does this test pass too?

      Queue
         .unbounded[IO, Int]
         .flatMap { q =>
           q.dequeue.timeout(1.second) *>
             q.enqueue1(1) *>
             q.enqueue1(2) *>
             q.dequeue1
         }
         .unsafeRunSync shouldBe 1

@pchlupacek
Copy link
Contributor Author

@mpilquist tests passes. As regard the exclusions, where to add them ?

@mpilquist
Copy link
Member

https://github.com/functional-streams-for-scala/fs2/blob/series/1.0/build.sbt#L197

@pchlupacek
Copy link
Contributor Author

Also going forward perhaps fro next release of fs2, I would like to explore, if we could implement Stream.bracket with similar signatures, essentially making canceling a stream instead of interrupting it. I think it could be possible and have bracket propagate the Case to finalizer, similarly like Bracket does in cats.

@mpilquist mpilquist merged commit b847c35 into series/1.0 Nov 6, 2018
@mpilquist mpilquist added this to the 1.0.1 milestone Dec 3, 2018
@SystemFw SystemFw deleted the bugfix/queue-get branch October 23, 2020 07:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants