Add bracketCancellable #1317
Add bracketCancellable #1317
Conversation
| def bracketCaseCancellable[F[x] >: Pure[x], R](acquire: F[R])( | ||
| release: (R, ExitCase[Throwable]) => F[Unit]): Stream[F, (Stream[F, INothing], R)] = | ||
| bracketWithToken(acquire)(release).map { | ||
| case (token, r) => (Stream.fromFreeC(Algebra.release(token, None)), r) |
There was a problem hiding this comment.
I'm not sure about the None here
There was a problem hiding this comment.
I've come to the conclusion that None is fine there, given that the canceler stream we are building here is not linked to the termination of the bracketed stream, and actually can't be because that defeats the point of an early finaliser. I therefore think this is ready for merge.
|
I decided to change the finaliser from ...
Stream.emit(1).flatTap(releaseStreamFromBracketCancellable)Which would compile and return an empty stream. On a separate note, it's not clear whether the initial motivation for making this combinator public (a leak in |
Useful for cases like #1312
Better have something like this in the public than creating an Algebra node in a high level operation like
groupWithin