Printing sinks should take ContextShift + EC #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monadplus
changed the title
mpilquist
reviewed
Mar 11, 2019
| _.map(_.show).through(text.encode(charset)).through(stdout(blockingExecutionContext)) | ||
|
|
||
| /** Stream of `String` read asynchronously from standard input decoded in UTF-8. */ | ||
| def stdinUtf8[F[_]](bufSize: Int, blockingExecutionContext: ExecutionContext)( |
There was a problem hiding this comment.
How about stdinText and taking a charset param defaulted to UTF8?
There was a problem hiding this comment.
Is this generalization possible ?
I though converting from bytes to string has to be done ad hoc.
There was a problem hiding this comment.
Oh, right, we don't have a decode(c: CharSet) method at this point in time.
There was a problem hiding this comment.
So how do I proceed ?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add stdoutLines and stdinLines as commented in the issue #1328