Add more file IO operations #1540
Conversation
|
@LukaJCB Any progress on this on? I'd love to get it in 1.1.0 release that's coming up soon. |
|
I'll have time to work on this tonight :) |
|
This should be good to review now, it doesn't comprise the full feature set, but it's a good start I think |
| * method in security sensitive applications. | ||
| */ | ||
| def exists[F[_]: Sync](path: Path, flags: Seq[LinkOption] = Seq.empty): F[Boolean] = | ||
| Sync[F].delay(Files.exists(path, flags: _*)) |
There was a problem hiding this comment.
Should this use Blocker since it's doing FS access?
There was a problem hiding this comment.
I wasn't sure in cases like these, since in general this should be super quick in most cases, but sure, I'll add it :)
There was a problem hiding this comment.
Yeah, I've felt the same way. Flip side is that pretty much everything in Files API grabs a global mutex when looking up a file system.
There was a problem hiding this comment.
I think it's important to use Blocker, even here. Think about checking existence on an NFS mount, or even something more benign like a FUSE mount.
Just a WIP for #1533