Added bracketWeak, bracketCaseWeak, and onFinalizeWeak to allow scope-less resource management #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh one note about this -- maybe since this allows registration to the current scope, we should make |
|
I restored |
mpilquist
changed the title
SystemFw
approved these changes
Sep 8, 2019
There was a problem hiding this comment.
Looks good to me. I think another advantage is that is easier to see which operations actually introduce a Scope given that bracket has a direct call to scope now.
Maybe some small bit of scaladoc could be added to onFinalizeWeak to show the only use case I know of it so far, namely things like
a.concurrently(b).onFinalizeWeak(something).compile.resource.lastOrError
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These three combinators behave like
bracket,bracketCase, andonFinalizedid in 1.0.5. One nice property of having these three operations is that we won't run in to a situation where someone was relying on the 1.0.5 behavior and there's no way to get it back in 1.1.0.