Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add TLS and DTLS support #1717

Merged
merged 48 commits into from
Jan 2, 2020
Merged

Add TLS and DTLS support #1717

merged 48 commits into from
Jan 2, 2020

Conversation

mpilquist
Copy link
Member

This PR adds the fs2.io.tls package, consisting of the types: TLSContext, TLSSocket (for TCP), and DTLSSocket (for UDP). This was originally based off fs2-crypto by @pchlupacek @AdamChlupacek and @mraulim but I ended up with a different approach to the internal TLSEngine class.

Usage examples are in the TLSSocketSpec and DTLSSocketSpec classes.

Note: requires building on Java 11+.

Fixes #1696.

@tpolecat
Copy link
Member

requires building on Java 11+

Will it also require downstream programs to build on 11, and/or applications to run on 11? I don't really care either way but Skunk users will want to know.

@mpilquist
Copy link
Member Author

@tpolecat No, TLS stuff will still run on Java 8+, though no DTLS support then.

@mpilquist
Copy link
Member Author

I added some docs on fs2-io to the guide -- treatment of non-networking sections is pretty light but better than nothing. This PR is ready for review.

@pchlupacek
Copy link
Contributor

@mpilquist seems good to me. Excellent work, thanks.

@mpilquist mpilquist merged commit 24427b7 into typelevel:master Jan 2, 2020
@tpolecat
Copy link
Member

tpolecat commented Jan 2, 2020

🎉 this is great! I will give it a go with Skunk in the next few days and let you know how it goes.

@SethTisue
Copy link
Member

congrats, you are the first repo in the entire Scala community build to drop support for building on JDK 8

(which is fine, it's not a problem, I just wanted to note this historic occasion)

@mpilquist mpilquist added this to the 2.2.0 milestone Jan 18, 2020
@mpilquist mpilquist deleted the topic/tls branch February 18, 2020 12:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import fs2-crypto in to fs2-io project
4 participants