-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add TLS and DTLS support #1717
Add TLS and DTLS support #1717
Conversation
… buffer - need to somehow flush that to a socket write
Will it also require downstream programs to build on 11, and/or applications to run on 11? I don't really care either way but Skunk users will want to know. |
@tpolecat No, TLS stuff will still run on Java 8+, though no DTLS support then. |
I added some docs on fs2-io to the guide -- treatment of non-networking sections is pretty light but better than nothing. This PR is ready for review. |
@mpilquist seems good to me. Excellent work, thanks. |
🎉 this is great! I will give it a go with Skunk in the next few days and let you know how it goes. |
congrats, you are the first repo in the entire Scala community build to drop support for building on JDK 8 (which is fine, it's not a problem, I just wanted to note this historic occasion) |
This PR adds the
fs2.io.tls
package, consisting of the types:TLSContext
,TLSSocket
(for TCP), andDTLSSocket
(for UDP). This was originally based off fs2-crypto by @pchlupacek @AdamChlupacek and @mraulim but I ended up with a different approach to the internalTLSEngine
class.Usage examples are in the
TLSSocketSpec
andDTLSSocketSpec
classes.Note: requires building on Java 11+.
Fixes #1696.