Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add evalMapChunk and evalTapChunk which operate on chunks #1793

Merged
merged 2 commits into from
Feb 27, 2020
Merged

Add evalMapChunk and evalTapChunk which operate on chunks #1793

merged 2 commits into from
Feb 27, 2020

Conversation

CremboC
Copy link
Contributor

@CremboC CremboC commented Feb 14, 2020 •
edited
Loading 

[info] Benchmark                   (n)   Mode  Cnt       Score       Error  Units
[info] StreamBenchmark.evalMap      10  thrpt    3  240385.919 ± 33389.928  ops/s
[info] StreamBenchmark.evalMap     100  thrpt    3   39834.763 ±  3967.529  ops/s
[info] StreamBenchmark.evalMap    1000  thrpt    3    4105.834 ±   867.816  ops/s
[info] StreamBenchmark.evalMap   10000  thrpt    3     212.373 ±  1205.824  ops/s
[info] StreamBenchmark.evalMaps     10  thrpt    3  230966.575 ± 89764.693  ops/s
[info] StreamBenchmark.evalMaps    100  thrpt    3   71055.648 ± 10100.526  ops/s
[info] StreamBenchmark.evalMaps   1000  thrpt    3    9802.130 ±   795.724  ops/s
[info] StreamBenchmark.evalMaps  10000  thrpt    3     881.018 ±    96.295  ops/s

Sorry, I accidentally switched a tab Chrome on the 10_000 run of evalMap, but it's around 300 ops/s in reality.

@CremboC CremboC changed the title Add evalMaps and evalTaps which operate on chunks Add evalMapChunk and evalTapChunk which operate on chunks Feb 17, 2020
@CremboC CremboC marked this pull request as ready for review February 17, 2020 08:13
@mpilquist mpilquist assigned mpilquist and unassigned mpilquist Feb 19, 2020
@mpilquist mpilquist self-requested a review February 19, 2020 13:11
@CremboC @diesalbla
Apply suggestions from code review
1c9b5df 
Co-Authored-By: Diego E. Alonso Blas <diesalbla@gmail.com>
@mpilquist mpilquist merged commit 3394d9f into typelevel:master Feb 27, 2020
@mpilquist mpilquist added this to the 2.3.0 milestone Mar 20, 2020
@bastewart bastewart mentioned this pull request Nov 23, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@diesalbla diesalbla diesalbla left review comments

@mpilquist mpilquist mpilquist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@CremboC @mpilquist @diesalbla