Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support for preemption-safe stream subscription #1817

Merged
merged 4 commits into from
Mar 20, 2020
Merged

Support for preemption-safe stream subscription #1817

merged 4 commits into from
Mar 20, 2020

Conversation

djspiewak
Copy link
Member

Fixes #1816

@SystemFw
Copy link
Collaborator

MiMa says no :(

@djspiewak
Copy link
Member Author

It's spurious because the parent type is package-private. I'll add an exclusion rule for it.

@djspiewak
Copy link
Member Author

I am very confused about these build failures.

@mpilquist
Copy link
Member

Just pushed a fix -- needed to run fmt on root project.

@mpilquist mpilquist self-requested a review March 20, 2020 00:08
@SystemFw SystemFw merged commit 684fa06 into typelevel:master Mar 20, 2020
@mpilquist mpilquist added this to the 2.3.0 milestone Mar 20, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mpilquist mpilquist mpilquist approved these changes

@SystemFw SystemFw SystemFw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

Reactive streams subscription cannot be handled uninterruptibly
3 participants
@djspiewak @SystemFw @mpilquist