Fix Chunk.traverse losing elements #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johnynek FYI |
|
Oh man. Sorry about that. Also the next version of cats exposes a method on object Chain that can do this code so we can share the implementation so hopefully all bugs get fixed quickly. I did make some changes in cats but I forgot to see if those changes were bugs in this PR. :( |
|
:) No worries. I knew you made those cats PRs so just wanted to give you a heads up in case we need similar fixes anywhere. |
|
The embarrassing part is that I noticed this in cats: But I forgot to look back to see if the bug was here. Cats tests exposed it. Sorry for dropping the ball there. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2001