Pull - Translate compilation - Fix error case. #2837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we get a unit test to cover this one? |
Was waiting for #2836 to be merged before writing one. |
If there is an error, it should be handled with the continuation of the `Translate` node, like most nodes.
diesalbla
force-pushed
the
fix_translate_err
branch
from
6708fd9 to
67b6848
Compare
|
Added a unit test to check interaction between |
We add a unit test to check the interaction between translate, raising error, and handling errors. We have confirmed that, without the changes to Pull translate interpretation, this test fails.
diesalbla
force-pushed
the
fix_translate_err
branch
from
a22eaad to
7b7f294
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is an error, it should be handled with the continuation of the
Translatenode, like most nodes.