FIX: Handle root path correctly

[InversionSpaces]

Drop trailing separators in Path creation only if it is not the only thing in the path.

Fixes #3353

[armanbilge]

It does actually 🤔 Here's what it's compiled to:

$c_Lfs2_io_file_Path$.prototype.dropTrailingSep__T__T = (function(path) {
  while (true) {
    if ($f_T__endsWith__T__Z($n(path), this.Lfs2_io_file_Path$__f_sep)) {
      var this$1 = $n(path);
      var this$2 = $n(this.Lfs2_io_file_Path$__f_sep);
      var $$x2 = (this$1.length > this$2.length)
    } else {
      var $$x2 = false
    };
    if ($$x2) {
      var $$x1 = $m_sc_StringOps$();
      var x = path;
      var this$4 = $n(this.Lfs2_io_file_Path$__f_sep);
      path = $n($$x1).dropRight$extension__T__I__T(x, this$4.length)
    } else {
      break
    }
  };
  return path
});

[armanbilge]

This passes for me. How were you getting the failure?

assertEquals(Path("/".repeat(Int.MaxValue/8)), Path("/"))

[InversionSpaces]

Strange, I wrote this comment when I used IndexedSeqView instead of String.

[armanbilge]

These if guards are probably skipping most/all of the generated values. Instead you should do something like this.

Suggested change

	forAll((sepLength: Int) =>
	if (sepLength >= 0 && sepLength <= 100)
	forAll(Gen.choose(0, 100))((sepLength: Int) =>

[armanbilge]

I don't like to Officially:tm: support Windows 🤮 but its path can look like C:\ which I think would get re-written to C:. I have no idea if that's good or bad 😅

[BalmungSan]

Doing some tests on Powershell

PS C:\Users\PC> cd c:
PS C:\Users\PC> cd C:
PS C:\Users\PC> cd C:\
PS C:\>

Thus, it seems they are not equivalent.

---

IMHO, it is best to avoid this specific Path modification, also it may be good to add a unit test verifying it.

[InversionSpaces]

Used node API exclusively

[armanbilge]

Wait a minute, is this test passing even when sepLength = 0?

[InversionSpaces]

No, it should not. After investigation I found out that scalacheck is mishandled in this suite. Tried to fix that

[armanbilge]

thank you!