Deprecate internal forAllShrink #457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shrinking failed tests will be deprecated when an explicit generator is given to forAll. Going forward, there should be another way for users to shrink failing tests. Naming it forAllShrink is the obvious candidate. This old version of forAllShrink taking a should be made private, and should also be updated to take an explicit Shrink[T] rather than an explicit T => Stream[T].
ashawley
force-pushed
the
deprecate-forallshrink
branch
from
d16e8ba to
8142c39
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #444, I noticed the existing
forAllShrink. This version offorAllShrinkshould be made private, and should also be updated to take an explicitShrink[T]rather than an explicitT => Stream[T]. This deprecates it and provides an alternate implementation.