Switch to Scala.js dependency for saslprep #587
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the npm dependency for saslprep with a pure Scala.js implementation. This lets us to dump npm, dump ScalaJSBundler, dump the 8000 lines of lockfiles, and all the associated maintenance burden.
The Scala saslprep implementation is just a port from MongoDB. I originally started adding this code directly to skunk, but I ended microlib-ing it instead because it seemed to be getting out-of-scope. It's a single file and test suite so happy to just include it in skunk if you don't mind the bloat (i.e. a stupid number of hardcoded UTF8 codepoints. Frustrating that Node.js doesn't have this stuff out-of-the-box).