Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: fix a typo #753

Merged
merged 5 commits into from
Oct 19, 2024
Merged

docs: fix a typo #753

merged 5 commits into from
Oct 19, 2024

Conversation

shxntanu
Copy link
Contributor

  • Add Vite to the setup (as the Vite react starter template is also very popular)
  • Fix a bracket typo on the HOC Cheatsheet part at the "All React + TypeScript Cheatsheets" section

@filiptammergard
Copy link
Collaborator

Hey! We don't want to add Vite for now for this reason: #735 (comment)

But the other fix is welcomed so please change the PR to only include that one.

@shxntanu
Copy link
Contributor Author

@filiptammergard Noted. I've removed Vite as per your suggestion.

I had one more suggestion on the HOC section. It would help if in the intro document, we could add the possible use cases of implementing an HOC (for example: Protecting a route by allowing only authenticated users to access it, or some routes may require certain user conditions to be met like a specific payment plan, etc.)

Since it's a cheatsheet, it would give a gist of where HOCs are typically used and readers can then take inspiration from it to build their own custom HOCs.

@shxntanu shxntanu changed the title docs: add Vite to setup and fix a typo docs: fix a typo Oct 19, 2024
@filiptammergard filiptammergard merged commit 15c1f00 into typescript-cheatsheets:main Oct 19, 2024
5 checks passed
@filiptammergard
Copy link
Collaborator

@filiptammergard Noted. I've removed Vite as per your suggestion.

I had one more suggestion on the HOC section. It would help if in the intro document, we could add the possible use cases of implementing an HOC (for example: Protecting a route by allowing only authenticated users to access it, or some routes may require certain user conditions to be met like a specific payment plan, etc.)

Since it's a cheatsheet, it would give a gist of where HOCs are typically used and readers can then take inspiration from it to build their own custom HOCs.

Feel free to open a PR. Not sure a gist would be needed but a few examples of use cases could be good.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants