Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(typescript-estree): remove slow deprecated and isolated programs #8834

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Apr 4, 2024

BREAKING CHANGE: Removes public API option around default programs.

PR Checklist

Overview

Removes program creation specific to the two linked issues. I found that createProjectProgram was only returning undefined when parseSettings.DEPRECATED__createDefaultProgram was truthy, which was how getProgramAndAST would fall back to an isolated program. Hence tackling both in the same PR.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 2004a86
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/660e0f5f533e9f0008337891
😎 Deploy Preview https://deploy-preview-8834--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone Apr 4, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the base branch from main to v8 April 4, 2024 02:33
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base (984f4cd) to head (2004a86).
Report is 40 commits behind head on v8.

❗ Current head 2004a86 differs from pull request most recent head 5c740df. Consider uploading reports for the commit 5c740df to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##               v8    #8834      +/-   ##
==========================================
+ Coverage   88.02%   88.04%   +0.01%     
==========================================
  Files         405      404       -1     
  Lines       14089    14068      -21     
  Branches     4125     4120       -5     
==========================================
- Hits        12402    12386      -16     
+ Misses       1382     1378       -4     
+ Partials      305      304       -1     
Flag Coverage Δ
unittest 88.04% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...-estree/src/create-program/createProjectProgram.ts 100.00% <100.00%> (ø)
...pt-estree/src/parseSettings/createParseSettings.ts 78.87% <ø> (ø)

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review April 6, 2024 15:48
@bradzacher bradzacher added the breaking change This change will require a new major version to be released label Apr 15, 2024
…gram.ts

Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@JoshuaKGoldberg JoshuaKGoldberg merged commit 8253e21 into typescript-eslint:v8 Apr 15, 2024
53 checks passed
JoshuaKGoldberg added a commit that referenced this pull request Apr 22, 2024
…#8834)

* feat(typescript-estree): remove slow deprecated and isolated programs

* Update packages/typescript-estree/src/create-program/createProjectProgram.ts

Co-authored-by: Brad Zacher <brad.zacher@gmail.com>

---------

Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
JoshuaKGoldberg added a commit that referenced this pull request Apr 22, 2024
* feat(typescript-estree): remove slow deprecated and isolated programs (#8834)

* feat(typescript-estree): remove slow deprecated and isolated programs

* Update packages/typescript-estree/src/create-program/createProjectProgram.ts

Co-authored-by: Brad Zacher <brad.zacher@gmail.com>

---------

Co-authored-by: Brad Zacher <brad.zacher@gmail.com>

* fix(typescript-estree): add TSEnumBody node for TSEnumDeclaration body (#8920)

* fix(typescript-estree): add TSEnumBody node for TSEnumDeclaration body

* Fixed up tests and their snapshots

* More about enums

* Indent too

* Update packages/ast-spec/src/special/TSEnumBody/spec.ts

Co-authored-by: Brad Zacher <brad.zacher@gmail.com>

* parent types touchups

* Update packages/visitor-keys/src/visitor-keys.ts

Co-authored-by: Brad Zacher <brad.zacher@gmail.com>

---------

Co-authored-by: Brad Zacher <brad.zacher@gmail.com>

* remove getTypeArguments

* one lil '

---------

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
JoshuaKGoldberg added a commit that referenced this pull request Apr 23, 2024
* feat(typescript-estree): remove slow deprecated and isolated programs (#8834)

* feat(typescript-estree): remove slow deprecated and isolated programs

* Update packages/typescript-estree/src/create-program/createProjectProgram.ts

Co-authored-by: Brad Zacher <brad.zacher@gmail.com>

---------

Co-authored-by: Brad Zacher <brad.zacher@gmail.com>

* fix(typescript-estree): add TSEnumBody node for TSEnumDeclaration body (#8920)

* fix(typescript-estree): add TSEnumBody node for TSEnumDeclaration body

* Fixed up tests and their snapshots

* More about enums

* Indent too

* Update packages/ast-spec/src/special/TSEnumBody/spec.ts

Co-authored-by: Brad Zacher <brad.zacher@gmail.com>

* parent types touchups

* Update packages/visitor-keys/src/visitor-keys.ts

Co-authored-by: Brad Zacher <brad.zacher@gmail.com>

---------

Co-authored-by: Brad Zacher <brad.zacher@gmail.com>

* chore(type-utils)!: remove IsNullableTypeOptions interface

---------

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
breaking change This change will require a new major version to be released
Projects
None yet
3 participants