-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(eslint-plugin): [no-unused-vars] incorporate upstream changes around caught errors report messages #9532
fix(eslint-plugin): [no-unused-vars] incorporate upstream changes around caught errors report messages #9532
Conversation
Thanks for the PR, @abrahamguo! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7bd3a69. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v8 #9532 +/- ##
==========================================
+ Coverage 88.00% 88.01% +0.01%
==========================================
Files 401 401
Lines 13647 13637 -10
Branches 3965 3960 -5
==========================================
- Hits 12010 12003 -7
Misses 1325 1325
+ Partials 312 309 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bd0ae83
to
368d1e1
Compare
…eslint into no-unused-vars
@abrahamguo did you mean to keep this as draft? |
Yep! Still have to integrate the second PR. Working on that now, hoping to finish it today or tomorrow 👍 |
…eslint into no-unused-vars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - very clean and straightforward. Yay!
But given that @kirkwaiblinger authored >1 of the linked PRs, I'll defer to Kirk. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for doing this!
PR Checklist
Overview