Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(eslint-plugin): [no-unused-vars] ignore imports used only as types #9694

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

jakebailey
Copy link
Collaborator

PR Checklist

Overview

If usedOnlyAsType, then ignore the variable if it came from an import definition. This showed that there were existing tests which encoded the old behavior, which I updated.

The second commit moves some code slightly to avoid extra work now that this loop can continue.

Due to #9688, I had to commit with --no-verify, so hopefully this passes CI.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @jakebailey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4190828
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66aaf82cb45acb0008c147da
😎 Deploy Preview https://deploy-preview-9694--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Aug 1, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4190828. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (c3f9dcd) to head (4190828).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9694   +/-   ##
=======================================
  Coverage   88.06%   88.07%           
=======================================
  Files         402      402           
  Lines       13687    13691    +4     
  Branches     3980     3982    +2     
=======================================
+ Hits        12054    12058    +4     
  Misses       1324     1324           
  Partials      309      309           
Flag Coverage Δ
unittest 88.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/eslint-plugin/src/rules/no-unused-vars.ts 99.00% <100.00%> (+0.02%) ⬆️

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick PR! ⚡

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Aug 1, 2024
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah gif

@JoshuaKGoldberg JoshuaKGoldberg merged commit 6a9674d into typescript-eslint:main Aug 1, 2024
63 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2024
@jakebailey jakebailey deleted the fix-9679 branch August 19, 2024 18:04
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: In v8, no-unused-vars says "defined but only used as type" on import with no escape hatch
3 participants