Koa multipart body #269
Koa multipart body #269
Conversation
src/driver/koa/KoaDriver.ts
Outdated
| @@ -111,6 +111,9 @@ export class KoaDriver extends BaseDriver implements Driver { | |||
| .forEach(param => { | |||
| defaultMiddlewares.push(multer(param.extraOptions).array(param.name)); | |||
| }); | |||
|
|
|||
| // HACK: should be removed when koa-multer merges #15: https://github.com/koa-modules/multer/pull/15 | |||
There was a problem hiding this comment.
No need to add the almost same comment twice, remove the comment here.
|
Ping @NoNameProvided - merge it if you approve it now 😉 |
|
Damn, thats why it bad to have failing tests, I assumed only the Cookie test fails on the latest stable but actually this PR brokes the added test in it. @fabiob did this works for you? It seems Koa fails the tests you wrote. |
|
I can confirm that the test fails on newest node.js. Fortunately, only the newly added test fails so it won't break any existing feature 😆 Because it fails also in express and not on older node versions, it looks like the second weird test bug on newest node. Bu the reason why both drivers return 400 Bad Request when using both decorators is that the default decorator option is |
|
@NoNameProvided I've fixed it in 5c7face, so now you can sleep safe & sound 😉 |
|
Thanks. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR fixes #156.
One of the new tests do fail when running under Gulp, but works fine when ran directly from mocha. I have no idea why.