Skip to content

Fix sync and async auth checker bug #283

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2017
Merged

Fix sync and async auth checker bug #283

merged 1 commit into from
Sep 9, 2017

Conversation

MichalLytek
Copy link
Contributor

@MichalLytek MichalLytek commented Sep 8, 2017 •
edited
Loading

Closes #282, fixes #262, resolve #240.

@MichalLytek MichalLytek added the type: fix Issues describing a broken feature. label Sep 8, 2017
@MichalLytek MichalLytek self-assigned this Sep 8, 2017
MichalLytek
MichalLytek commented Sep 8, 2017
View reviewed changes
Copy link
Contributor Author

@MichalLytek MichalLytek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github diff is awful, it's better to look at this in vscode.

@MichalLytek MichalLytek mentioned this pull request Sep 9, 2017
Closed
NoNameProvided
NoNameProvided approved these changes Sep 9, 2017
View reviewed changes
Copy link
Member

@NoNameProvided NoNameProvided left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@NoNameProvided NoNameProvided merged commit 2f94fbb into typestack:master Sep 9, 2017
@MichalLytek MichalLytek mentioned this pull request Sep 22, 2017
Closed
@thormengkheang
Copy link

thormengkheang commented Sep 26, 2017 •
edited
Loading

When version 0.7.3 release? because i really need this feature in my koa project. @19majkel94

@pleerock
Copy link
Contributor

it has been released yesterday

@thormengkheang
Copy link

@pleerock thanks just saw it

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@NoNameProvided NoNameProvided NoNameProvided approved these changes

Assignees

@MichalLytek MichalLytek

Labels
type: fix Issues describing a broken feature.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Koa still return 404 when with Authorized async action with Authorized return 404 Bug with Authorized() (only 0.7.1)
4 participants
@MichalLytek @thormengkheang @pleerock @NoNameProvided