Skip to content

feat: add option to dispose scoped container #556

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

attilaorosz
Copy link
Member

Description

Add scopedContainerDisposer to SocketControllersOptions to be able to dispose scoped containers after the action is finished

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #553

@attilaorosz attilaorosz merged commit 837f131 into develop Feb 1, 2023
@attilaorosz attilaorosz deleted the feat/scoped-container-disposer branch February 1, 2023 17:04
@github-actions
Copy link

github-actions bot commented Mar 4, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

feature: scoped container disposer
1 participant