Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

husky 4.2.3 rolled back to 4.2.1 so that it works #676

Closed
basher opened this issue Feb 20, 2020 · 3 comments · Fixed by #687
Closed

husky 4.2.3 rolled back to 4.2.1 so that it works #676

basher opened this issue Feb 20, 2020 · 3 comments · Fixed by #687

Comments

@basher
Copy link

basher commented Feb 20, 2020 •
edited
Loading

I setup a POC project to test Parcel bundler a few weeks ago (for a static HTML website).

  • At that time, I ran husky@4.2.1 and lint-staged@10.0.2.
  • Pre-commit worked OK via VS Code bash terminal.

Today, I setup a new project (for a .NET MVC website) with the same package.json and folder structure as per my POC.

  • Package versions have moved on to husky@4.2.3 and lint-staged@10.0.7.
  • None of my SCSS or JS files were being linted during pre-commit.
  • Husky didn't run at all - i.e. there was no console message husky > pre-commit (node v12.14.1), etc. It failed silently.

I rolled husky back to 4.2.1 and pre-commit now works again.
@chadfurman
Copy link

Same. Thanks for this!

@coconilu
Copy link

coconilu commented Mar 9, 2020

At macos，when I use cnpm install 4.2.3，it dosen't works.But when I use yarn install, it works.

afc163 added a commit to afc163/husky that referenced this issue Mar 10, 2020
@afc163
fix: cnpm fail cause packgeManager not matched
20810c0 
close typicode#682
close typicode#676
close cnpm/cnpm#318
@afc163 afc163 mentioned this issue Mar 10, 2020
Merged
@chriseppstein
Copy link

This was broken for me at 4.2.3 as well. Rolling back to 4.2.1 fixed it. I'm not using cnpm... just using yarn.

chriseppstein added a commit to linkedin/css-blocks that referenced this issue Apr 4, 2020
@chriseppstein
fix: Work around for husky regression.
1783a7e 
Husky fails to run commitlint silently in 4.2.3. I've rolled back to
4.2.1 and locked the version there until the issue is fixed.

typicode/husky#676
typicode pushed a commit that referenced this issue Apr 9, 2020
@afc163
fix: cnpm fails due to $packgeManager not matched (#687)
4e1d440 
* fix: cnpm fail cause packgeManager not matched

close #682
close #676
close cnpm/cnpm#318

* test: fix jest snapshot
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: cnpm fails due to $packgeManager not matched afc163/husky
4 participants
@chriseppstein @basher @chadfurman @coconilu