Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update GitHub style and add GitHub darkmode #3

Closed
wants to merge 3 commits into from

Conversation

skullface
Copy link

@skullface skullface commented Aug 9, 2019

👋 A happy Typora user and GitHub power user here! :octocat:💕 This PR:

  1. updates the Github theme to better align to GitHub’s Primer styling, specifically the PR/Issue view on github.com.
  2. includes a(n unofficial 😉!) darkmode version of the above updates.

Like #2, this PR removes the custom font in favor of a native font stack.

Before After
Screen Shot 2019-08-28 at 5 53 07 PM Screen Shot 2019-08-28 at 5 50 37 PM

@skullface
Copy link
Author

👋 @abnerlee

@abnerlee
Copy link
Contributor

@skullface

Sorry for late. But possible to submit this as an seperate theme on https://github.com/typora/typora-theme-gallery? You can name it like "Primer", or whatever you like.

Typora use this as "default" theme (although it is named "Github" theme), so we should be much careful to change / modify this.

@skullface
Copy link
Author

Thank so much @abnerlee! I think the name of the Typora default theme should be changed to "Default" since it’s not really accurate to GitHub’s styling. I will submit the PR to the theme gallery.

@skullface skullface closed this Aug 3, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants