add CORS headers #608
Merged
add CORS headers #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will allow external portal on the network to send credentials via browser.
this will allow external portal on the network to send credentials via browser.
add CORS headers
|
Should we make this optional or allow passing in parameters for source and access control ? |
|
in the rare case of someone connected to WiFiManager while browsing websites on internet this could be a security issue - as the website might send ESP wrong wifi credentials and make it useless. but we can add it as parameter. |
|
Yeah it would be a very specific xss attack but who knows. |
|
Any info about when will this be released ? Thanks |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will allow external portal on the network to send credentials via browser.