Merge pull request #4 from tzickel/py39

Py39 testing support

Dockerfile.test

@@ -2,23 +2,21 @@ ARG BASE_IMAGE=quay.io/pypa/manylinux2014_x86_64
 FROM $BASE_IMAGE
 
 ARG REDIS5_VERSION=5.0.9
-ARG REDIS6_VERSION=5.0.8
+ARG REDIS6_VERSION=6.0.8
 RUN cd /tmp && mkdir redis5 && curl -s https://download.redis.io/releases/redis-${REDIS5_VERSION}.tar.gz | tar -xvzo -C redis5 --strip-components=1 > /dev/null 2>&1 && cd redis5 && make > /dev/null 2>&1
 RUN cd /tmp && mkdir redis6 && curl -s https://download.redis.io/releases/redis-${REDIS6_VERSION}.tar.gz | tar -xvzo -C redis6 --strip-components=1 > /dev/null 2>&1 && cd redis6 && make > /dev/null 2>&1
 
 ARG PYPY3_VERSION=7.3.2
 RUN cd /opt/python && mkdir pypy3 && curl -s -L https://downloads.python.org/pypy/pypy3.6-v${PYPY3_VERSION}-linux64.tar.bz2 | tar -xvjo -C pypy3 --strip-components=1 > /dev/null 2>&1
 
 #WORKDIR /opt
-
 #ADD https://api.github.com/repos/tzickel/justredis/git/refs/heads/master version.json
-
 #RUN git clone https://github.com/tzickel/justredis
 
 WORKDIR /opt/justredis
 
 ADD . .
 
 RUN /opt/python/cp38-cp38/bin/pip install -U tox pip setuptools wheel > /dev/null 2>&1
-RUN REDIS_6_PATH=/tmp/redis6/src REDIS_5_PATH=/tmp/redis5/src PATH=$PATH:/opt/python/cp38-cp38/bin:/opt/python/cp37-cp37m/bin:/opt/python/cp36-cp36m/bin:/opt/python/cp35-cp35m/bin:/opt/python/pypy3/bin /opt/python/cp38-cp38/bin/tox
-RUN /opt/python/cp38-cp38/bin/python setup.py sdist bdist_wheel
+RUN REDIS_6_PATH=/tmp/redis6/src REDIS_5_PATH=/tmp/redis5/src PATH=$PATH:/opt/python/cp39-cp39/bin:/opt/python/cp38-cp38/bin:/opt/python/cp37-cp37m/bin:/opt/python/cp36-cp36m/bin:/opt/python/cp35-cp35m/bin:/opt/python/pypy3/bin /opt/python/cp38-cp38/bin/tox
+RUN /opt/python/cp38-cp38/bin/python setup.py bdist_wheel

README.md

@@ -8,6 +8,7 @@ A Redis client for Python supporting many Redis features and Python synchronous
 - Per context and command properties (database #, decoding, RESP3 attributes)
 - Asynchronous I/O support with the same exact API (but with the await keyword), targeting asyncio, trio and curio (using [AnyIO](https://github.com/agronholm/anyio) which needs to be installed as well if you want async I/O)
 - Modular API allowing for easy support for multiple synchronous and asynchronous event loops and disabling of unneeded features
+- CI Testing for CPython 3.5, 3.6, 3.7, 3.8, 3.9 and PyPy3 with Redis 5 and Redis 6
 - No legacy support for old language features
 
 ## Redis features support table
@@ -32,16 +33,15 @@ Getting it out of alpha:
   - [ ] Is the modify() API flexiable enough ?
   - [ ] Is it easy to extend the module ?
   - [ ] Should we add helper functions for SCAN iterators and other API ?
-- [ ] Asynchronous support
-  - [ ] Automate code convertion between sync and async
-  - [ ] Make sure cancelations are handled properly
 - [ ] Resolving some of the TODO in code
 
 General:
 - More features in the support table
 - Better test coverage
 - Resolve all TODO in code
 - Move documentation to topics + docstrings
+- Automate code convertion between sync and async
+- More CI checks such as flake8, pylint, etc..
 
 ## Not on roadmap (for now?)
 

justredis/nonsync/redis.py

@@ -65,10 +65,13 @@ def __init__(self, pool_factory=ClusterConnectionPool, custom_command_class=None
         """
         Currently documented in README.md
         """
+        self._connection_pool = None
         if pool_factory == "pool":
             pool_factory = ConnectionPool
         elif pool_factory in ("auto", "cluster"):
             pool_factory = ClusterConnectionPool
+        if not hasattr(pool_factory, "__call__"):
+            raise AttributeError("A valid pool_factory is required, if you want to set address, use .from_url() or address=(host, port)")
         super(Redis, self).__init__(pool_factory(**kwargs), custom_command_class=custom_command_class)
 
     async def aclose(self):

justredis/sync/redis.py

@@ -67,10 +67,13 @@ def __init__(self, pool_factory=ClusterConnectionPool, custom_command_class=None
         """
         Currently documented in README.md
         """
+        self._connection_pool = None
         if pool_factory == "pool":
             pool_factory = ConnectionPool
         elif pool_factory in ("auto", "cluster"):
             pool_factory = ClusterConnectionPool
+        if not hasattr(pool_factory, "__call__"):
+            raise AttributeError("A valid pool_factory is required, if you want to set address, use .from_url() or address=(host, port)")
         super(Redis, self).__init__(pool_factory(**kwargs), custom_command_class=custom_command_class)
 
     def __del__(self):

tox.ini

@@ -1,15 +1,15 @@
 [tox]
-envlist = clean,py{35,36,37,38,py3}
+envlist = clean,py{35,36,37,38,39,py3}
 #isolated_build = true
 skip_missing_interpreters = true
 
 [testenv]
 deps =
   pytest
   pytest-cov
-  py{36,37,38,py3}: anyio[trio,curio]
+  py{36,37,38,39,py3}: anyio[trio,curio]
 commands =
-  py{35,36,37,38,py3}: pytest --cov={toxinidir}/justredis --cov={toxinidir}/tests --cov-append --cov-report=term-missing {posargs}
+  py{35,36,37,38,39,py3}: pytest --cov={toxinidir}/justredis --cov={toxinidir}/tests --cov-append --cov-report=term-missing {posargs}
 passenv =
   REDIS_6_PATH
   REDIS_5_PATH