-
Notifications
You must be signed in to change notification settings - Fork 90
Add eula enforcement #609
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Add eula enforcement #609
Conversation
… show up on allocation detail page
Whats the status of this PR? I'm looking to get it merged and am happy to contribute. |
@jrlagrone Apologies for the delay in reviewing this PR. If you're still interested in getting this merged can you fix any conflicts with the main branch and rebase this PR into a single commit with |
I can do that, I'll try to get to it next week. |
The requested changes should be in #671. I didn't see an obvious way of changing the source branch for the merge on this PR and we're interested in keeping the non-squashed version history locally, so I just made a new branch and PR. |
This is largely based on PR #550 by @rg663 and aims to resolve #542 (and #420?)
Users added to an allocation must agree to the EULA for the associated resource, if it exists.
This adds
PendingEULA
andDeclinedEULA
statuses to allocation users. An allocation is available to an user if the status of the allocation and the users allocation status are bothActive
. An allocation may be active for some users added to it, but not all added users based on whether or not they accepted the EULA (if applicable). PI's must accept the EULA to submit an allocation request, where enabled.This attaches EULA agreements to individual allocations, but EULAs are associated with resources. This means an user has to agree to the EULA for each individual allocation on a given resource.
PIs agree to the EULA when submitting an allocation request.
Some things to consider testing (in addition to those listed in #542):
DEBUG=True PLUGIN_SLURM=True coldfront slurm_dump
and verify that output matches expectationsDeclinedEULA
->PendingEULA
status.EULA_AGREEMENT = False
should disable eula enforcement. Switching that on/off may result in some unexpected behaviors though.