OOD added job_name #241
Merged
OOD added job_name #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpalmer
suggested changes
Jun 30, 2020
Comment on lines
68
to
79
| $this->addTable( $joblistTable ); | ||
| $this->addTable( $factTable ); | ||
|
|
||
| // This is used by Integrations and not currently shown on the XDMoD interface | ||
| $jobnameTable = new Table(new Schema('modw_supremm'), "job_name", "jn" ); | ||
| $this->addWhereCondition(new WhereCondition(new TableField($factTable, "jobname_id"), '=', new TableField($jobnameTable, "id") )); | ||
| $this->addField(new TableField($jobnameTable, 'name', 'job_name')); | ||
| $this->addTable($jobnameTable ); | ||
|
|
||
| $this->addWhereCondition(new WhereCondition( new TableField($joblistTable, "agg_id"), "=", | ||
| new TableField($dataTable, "id") )); | ||
| $this->addWhereCondition(new WhereCondition( new TableField($joblistTable, "jobid"), "=", |
There was a problem hiding this comment.
Can these additions safely be moved to below the joins? Right now it's between where the job list and fact tables are added and then joined. The file already has some odd structure, but I think it would be best to keep the existing logically related code together.
jtpalmer
approved these changes
Jun 30, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open OnDemand asked for the ability to show
job_namethis adds it. This was originally in8.7this brings it in to 9.0.