Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bug fixes: Add mask and make chart name unique #1028

Merged
merged 2 commits into from
Sep 11, 2019
Merged

Conversation

mkzia
Copy link
Contributor

@mkzia mkzia commented Sep 6, 2019

Description

Fix bug: Chart Thumbnail open in metric explorer fails if existing chart has same name
Fix bug: Chart Thumbnail model chart missing loading mask
Fix bug: Refresh field in the search bar for saved charts and reports is cleared when refresh is clicked

Motivation and Context

Bug Fix

Tests performed

Manual test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mkzia mkzia requested a review from jpwhite4 September 6, 2019 22:09
@mkzia mkzia merged commit 891566d into ubccr:xdmod8.5 Sep 11, 2019
@plessbd plessbd added this to the 8.5.0 milestone Oct 16, 2019
@plessbd plessbd added bug Bugfixes Category:User Dashboard Screen shown after user login labels Oct 16, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Bugfixes Category:User Dashboard Screen shown after user login
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants