Fix the underlying JSON configuration parsing problems #1131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
XDMoDConfiguration
class has problems parsing some of the xdmod configuration files. There have been a couple of attempts to workaround the problem notably f989888 and 7c497acbut both of these did not fix the underlying design problem.
The underlying problem is that the
JsonFile.php
parser is designed to be usedto parse structured record-based json data. It includes support for parsing hybid json-like files
that contain multiple json blobs and it has code that validates the files based on a very
limited set of allowable content structure. The XDMoD configuration files are not record-based
json, they do not contain multiple json blobs and they do not conform to the content structure
that the JsonFile class is designed to handle.
My proposed solution is to stop using the record-based parser for the config data.
This change also backs out the now unneeded workarounds and updates the test artifacts appropriately.