Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix the underlying JSON configuration parsing problems #1131

Merged
merged 1 commit into from
Dec 31, 2019

Conversation

jpwhite4
Copy link
Member

@jpwhite4 jpwhite4 commented Oct 25, 2019

Description

The XDMoDConfiguration class has problems parsing some of the xdmod configuration files. There have been a couple of attempts to workaround the problem notably f989888 and 7c497ac
but both of these did not fix the underlying design problem.

The underlying problem is that the JsonFile.php parser is designed to be used
to parse structured record-based json data. It includes support for parsing hybid json-like files
that contain multiple json blobs and it has code that validates the files based on a very
limited set of allowable content structure. The XDMoD configuration files are not record-based
json, they do not contain multiple json blobs and they do not conform to the content structure
that the JsonFile class is designed to handle.

My proposed solution is to stop using the record-based parser for the config data.

This change also backs out the now unneeded workarounds and updates the test artifacts appropriately.

@jpwhite4 jpwhite4 added experiment Experimental feature Category:ETL Extract Transform Load labels Oct 25, 2019
@jpwhite4 jpwhite4 added this to the 9.0.0 milestone Oct 25, 2019
@jpwhite4 jpwhite4 changed the title WIP test Proposed Fix for the underlying json config parsing problems Oct 25, 2019
@jpwhite4 jpwhite4 requested a review from ryanrath October 28, 2019 14:44
@ryanrath
Copy link
Contributor

ryanrath commented Nov 5, 2019

@jpwhite4 quick question before approving this one. Was this the PR where you were talking about redoing the inheritance of JsonConfigFile class? Or was that another one?

@jpwhite4 jpwhite4 removed the experiment Experimental feature label Dec 31, 2019
@jpwhite4 jpwhite4 merged commit 3defcae into ubccr:xdmod9.0 Dec 31, 2019
@jpwhite4 jpwhite4 deleted the conf_fix branch December 31, 2019 15:36
@jtpalmer jtpalmer added the bug Bugfixes label Aug 10, 2020
@jtpalmer jtpalmer changed the title Proposed Fix for the underlying json config parsing problems Fix the underlying JSON configuration parsing problems Aug 10, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Bugfixes Category:ETL Extract Transform Load
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants