Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add additional ETL DB Model error checking #1237

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

jtpalmer
Copy link
Contributor

@jtpalmer jtpalmer commented Feb 26, 2020

Description

Adds additional error checking to the initialize functions of the index and foreign key constraint database models.

Motivation and Context

The initialize functions use the columns from the configuration when a name is not specified. The columns are required local properties of the entities, but their existence is not verified until the parent initialize function is called. This function must be called last in the child initialize because the parent initialize uses the name configuration to set the entities name.

Without this change any missing columns produce an Undefined property: stdClass::$columns error which cannot be caught and logged.

Tests performed

Added new tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtpalmer jtpalmer added the Category:ETL Extract Transform Load label Feb 26, 2020
@jtpalmer jtpalmer added this to the 9.0.0 milestone Feb 26, 2020
@jtpalmer jtpalmer requested review from plessbd and jpwhite4 February 26, 2020 19:48
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jtpalmer jtpalmer merged commit fefdbc5 into ubccr:xdmod9.0 Feb 27, 2020
@jtpalmer jtpalmer deleted the etl-model-init branch February 27, 2020 13:19
@jtpalmer jtpalmer added the enhancement Enhancement of the functionality of an existing feature label Aug 10, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Category:ETL Extract Transform Load enhancement Enhancement of the functionality of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants