Add additional ETL DB Model error checking #1237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds additional error checking to the initialize functions of the index and foreign key constraint database models.
Motivation and Context
The
initialize
functions use thecolumns
from the configuration when aname
is not specified. Thecolumns
are required local properties of the entities, but their existence is not verified until the parentinitialize
function is called. This function must be called last in the childinitialize
because the parentinitialize
uses thename
configuration to set the entitiesname
.Without this change any missing columns produce an
Undefined property: stdClass::$columns
error which cannot be caught and logged.Tests performed
Added new tests.
Types of changes
Checklist: