Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update openstack json event schema definition #1249

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

eiffel777
Copy link
Contributor

Update the json schema for openstack events to allow null for the user_name field. This allows events whose user_name field has a null value to be ingested. Any event with a user_name of null will be assigned to the unknown value when aggregated.

Tests performed

Tested in docker

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@eiffel777 eiffel777 added bug Bugfixes Category:Cloud Cloud Realm labels Mar 9, 2020
@eiffel777 eiffel777 added this to the 9.0.0 milestone Mar 9, 2020
@eiffel777 eiffel777 self-assigned this Mar 9, 2020
@plessbd
Copy link
Contributor

plessbd commented Mar 9, 2020

Do we have any use cases in docker that this was actually hitting?
I didnt think we had any null cases in docker/

@jpwhite4
Copy link
Member

Please can you briefly list the testing performed on this change.

@eiffel777
Copy link
Contributor Author

@plessbd @jpwhite4 There weren't any cases for data that was already in the docker. I tested by spinning up a docker instance and then ingested some of the lakeeffect openstack data that did have null values in the user_name field. Before the change there were warnings such as this one.

2020-03-12 06:35:16 [warning] Record 8: NULL value found, but a string is required

These warning no longer occur once this change is applied.

@eiffel777 eiffel777 merged commit 2db78ac into ubccr:xdmod9.0 Mar 13, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Bugfixes Category:Cloud Cloud Realm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants