Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Rename report file name input field #1281

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Rename report file name input field #1281

merged 1 commit into from
Apr 8, 2020

Conversation

jtpalmer
Copy link
Contributor

@jtpalmer jtpalmer commented Apr 7, 2020

Description

Rename report generator "File Name" to "Report Name".

Motivation and Context

https://app.asana.com/0/15230011293693/62691924780819

Tests performed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtpalmer jtpalmer added bug Bugfixes Category:Report Generator Report Generator labels Apr 7, 2020
@jtpalmer jtpalmer added this to the 9.0.0 milestone Apr 7, 2020
@jtpalmer jtpalmer requested review from plessbd and jpwhite4 April 7, 2020 16:50
@jtpalmer
Copy link
Contributor Author

jtpalmer commented Apr 7, 2020

SonarCloud is failing due to duplications on new lines, but I'm not sure that's relevant.

@jtpalmer jtpalmer merged commit cabf364 into ubccr:xdmod9.0 Apr 8, 2020
@jtpalmer jtpalmer deleted the report-generator-report-name branch April 8, 2020 11:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@plessbd plessbd plessbd approved these changes

@jpwhite4 jpwhite4 Awaiting requested review from jpwhite4

Assignees
No one assigned
Labels
bug Bugfixes Category:Report Generator Report Generator
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpalmer @plessbd