Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Switch to new report after "Save As" #1302

Merged
merged 3 commits into from
May 4, 2020

Conversation

jtpalmer
Copy link
Contributor

@jtpalmer jtpalmer commented May 2, 2020

Description

After saving a report using "Save As" the report that is currently being edited is switched to the newly created report.

Motivation and Context

https://app.asana.com/0/15230011293693/62691924780821

Tests performed

Updated automated tests. Tested manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtpalmer jtpalmer added bug Bugfixes Category:Report Generator Report Generator labels May 2, 2020
@jtpalmer jtpalmer added this to the 9.0.0 milestone May 2, 2020
plessbd
plessbd previously approved these changes May 4, 2020
@jtpalmer
Copy link
Contributor Author

jtpalmer commented May 4, 2020

SonarCloud does not work well:
Screenshot from 2020-05-04 12-38-03
That file is not changed.

I'll rebase and force push...

@jtpalmer jtpalmer force-pushed the report-generator-save-as-switch branch from a65df8b to 55ba6a4 Compare May 4, 2020 16:40
@plessbd
Copy link
Contributor

plessbd commented May 4, 2020

Yeah, sometimes it does seem like sonar gets confused...
It isnt an actual blocker to merging so I think we are good.

@jtpalmer jtpalmer merged commit b64e70e into ubccr:xdmod9.0 May 4, 2020
@jtpalmer jtpalmer deleted the report-generator-save-as-switch branch May 4, 2020 17:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Bugfixes Category:Report Generator Report Generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants