Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change ETL logging identification strings #1316

Merged
merged 1 commit into from
May 22, 2020

Conversation

jtpalmer
Copy link
Contributor

Description

Replaces the DWI identification strings with more specific names.

Motivation and Context

The ident DWI has a specific meaning in the XSEDE ETL processes. It is used to identify the dw_extract_transform_load process. There is a script that checks to make sure this process has been run in the past couple days. If all these other scripts use the same ident then the check script is unable to notify us that the ETL script has not been running.

Tests performed

I haven't tested this. I'm not sure if there could be any side effects so I've requested reviews from many team members.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtpalmer jtpalmer added the Category:ETL Extract Transform Load label May 21, 2020
@jtpalmer jtpalmer added this to the 9.0.0 milestone May 21, 2020
Copy link
Contributor

@jsperhac jsperhac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me, Jeff. More specific information in logs is always desirable.

@jtpalmer jtpalmer merged commit 5ea1e83 into ubccr:xdmod9.0 May 22, 2020
@jtpalmer jtpalmer deleted the change-etl-ident branch May 22, 2020 18:20
@jtpalmer jtpalmer added the enhancement Enhancement of the functionality of an existing feature label Aug 10, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Category:ETL Extract Transform Load enhancement Enhancement of the functionality of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants