Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update PhantomJS unit tests #1325

Merged
merged 3 commits into from
Jun 1, 2020
Merged

Conversation

jtpalmer
Copy link
Contributor

@jtpalmer jtpalmer commented Jun 1, 2020

Description

Replaces use of RawGit with unpkg. Changes the version of chai to 3.4.1 because version 3.4.2 is not available on npm. Also adds an onResourceError handler to improve debugging.

Motivation and Context

These unit tests were failing on Travis CI and RawGit has reached the end of its useful life.

Tests performed

Tested manually and on Travis CI.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtpalmer jtpalmer added qa / testing Updates/additions to tests Category:Infrastructure Internal infrastructure updates/changes labels Jun 1, 2020
@jtpalmer jtpalmer requested review from plessbd and jpwhite4 June 1, 2020 16:45
@plessbd
Copy link
Contributor

plessbd commented Jun 1, 2020

Any reason you picked unpkg over jsDelivr?

Really I have no opinion just wondering if there was any reasons.

Shippable will fail unti our cloud issues are resolved.

@jtpalmer
Copy link
Contributor Author

jtpalmer commented Jun 1, 2020

I picked unpkg because I've seen it used somewhere. I don't remember where I saw it.

@plessbd
Copy link
Contributor

plessbd commented Jun 1, 2020

as good of a reason as I would have had for using any of the others, so works for me.

@jtpalmer jtpalmer merged commit 684d07a into ubccr:xdmod9.0 Jun 1, 2020
@jtpalmer jtpalmer deleted the phantomjs-unit-tests branch June 1, 2020 17:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Category:Infrastructure Internal infrastructure updates/changes qa / testing Updates/additions to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants