Enforce secure cookie flag for all session cookies and the REST token #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also enables https:// for the CI builds. The helper function start_session() was the cleanest way I could think of to enforce the secure falg for the session cookie. If anyone can think of a better way then let me know.
jpwhite4
commented
Jun 26, 2020
| @@ -37,7 +37,7 @@ build: | |||
| - ./tests/ui/runtests.sh --headless --log-junit `pwd`/shippable/testresults --sso | |||
| - ./vendor/phpunit/phpunit/phpunit -c ./tests/integration/phpunit.xml.dist --testsuite sso --log-junit `pwd`/shippable/testresults/xdmod-sso-integration.xml | |||
| - mv ./configuration/portal_settings.ini.old ./configuration/portal_settings.ini | |||
| - test ! -s /var/log/xdmod/apache-error.log | |||
| - test `fgrep -v ' [ssl:warn] ' /var/log/xdmod/apache-error.log | wc -l` = 0 | |||
There was a problem hiding this comment.
This is needed because the hostname of the autogenerated ssl cert is not localhost so the webserver logs a warning (but starts up anyway).
plessbd
approved these changes
Jun 26, 2020
jtpalmer
changed the title
jtpalmer
added
Category:General
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also enables https:// for the CI builds.
The helper function start_session() was the cleanest way I could think
of to enforce the secure falg for the session cookie. If anyone can think
of a better way then let me know.