Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update PHP version check #1366

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Update PHP version check #1366

merged 1 commit into from
Jul 8, 2020

Conversation

jtpalmer
Copy link
Contributor

@jtpalmer jtpalmer commented Jul 8, 2020

Description

Updates the xdmod-check-config script to warn about PHP 7. Also changes the comparison function used.

Motivation and Context

We've been getting more support requests from users that have PHP 7 installed and Open XDMoD does not currently work with PHP 7.

Tests performed

Tested manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtpalmer jtpalmer added enhancement Enhancement of the functionality of an existing feature Category:General General labels Jul 8, 2020
@jtpalmer jtpalmer merged commit 8ebd361 into ubccr:xdmod9.0 Jul 8, 2020
@jtpalmer jtpalmer deleted the php7-version-check branch July 8, 2020 18:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@plessbd plessbd

Assignees
No one assigned
Labels
Category:General General enhancement Enhancement of the functionality of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpalmer @plessbd