-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Generate png
and pdf
from svg
#1428
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plessbd
force-pushed
the
more-charting-updates
branch
from
August 21, 2020 17:30
02eb513
to
25bce42
Compare
plessbd
force-pushed
the
more-charting-updates
branch
from
August 21, 2020 18:04
25bce42
to
0be9f59
Compare
Need to update the documentation for the new dependency on exiftool and dropping ghostscript.
also you are missing the perl-Efittool infor from the Centos 7 section in the same file. |
jpwhite4
reviewed
Aug 21, 2020
Don't forget to update the pull request title and turn it into a proper sentence for the changelog. Also need to add the appropraite labels and milestone tags. |
plessbd
added
Category:General
General
maintenance / code quality
Improvements and code cleanup. Not a new feature or enhancement to existing functionality.
labels
Aug 21, 2020
plessbd
changed the title
Generate
Export of Aug 21, 2020
png
and pdf
from svg
png
and pdf
now generated from the same svg
plessbd
changed the title
Export of
Export of Aug 21, 2020
png
and pdf
now generated from the same svg
png
and pdf
now generated from the same svg
with similar metadata
plessbd
changed the title
Export of
Export of Aug 21, 2020
png
and pdf
now generated from the same svg
with similar metadatapng
and pdf
now generated from the same svg
both containing the "same" metadata
plessbd
changed the title
Export of
Add exif metadata to charts exported in Aug 21, 2020
png
and pdf
now generated from the same svg
both containing the "same" metadatapng
format.
plessbd
changed the title
Add exif metadata to charts exported in
Generate Aug 21, 2020
png
format.png
and pdf
from `svg
jpwhite4
approved these changes
Aug 21, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
autodoc:ignore
Auto documentation ignore this PR
Category:General
General
maintenance / code quality
Improvements and code cleanup. Not a new feature or enhancement to existing functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of using
chromium
to generate both thesvg
andpng
, this has it just generate thesvg
and then usesrsvg-convert
to create both thepng
and thepdf
and adds the exif data for bothpng
andpdf
This also combines the two commands
rsvg-convert
andexiftool
to be run in oneproc_open