Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Generate png and pdf from svg #1428

Merged
merged 3 commits into from
Aug 21, 2020
Merged

Conversation

plessbd
Copy link
Contributor

@plessbd plessbd commented Aug 21, 2020

instead of using chromium to generate both the svg and png, this has it just generate the svg and then uses rsvg-convert to create both the png and the pdf and adds the exif data for both png and pdf

This also combines the two commands rsvg-convert and exiftool to be run in one proc_open

@plessbd plessbd force-pushed the more-charting-updates branch from 02eb513 to 25bce42 Compare August 21, 2020 17:30
@plessbd plessbd requested a review from jpwhite4 August 21, 2020 18:03
@plessbd plessbd force-pushed the more-charting-updates branch from 25bce42 to 0be9f59 Compare August 21, 2020 18:04
@jpwhite4
Copy link
Member

Need to update the documentation for the new dependency on exiftool and dropping ghostscript.

grep -w ghostscript -R docs
docs/software-requirements.md:                  ghostscript php-mbstring php-pecl-apcu jq \

also you are missing the perl-Efittool infor from the Centos 7 section in the same file.

@jpwhite4
Copy link
Member

Don't forget to update the pull request title and turn it into a proper sentence for the changelog. Also need to add the appropraite labels and milestone tags.

@plessbd plessbd added this to the 9.5.0 milestone Aug 21, 2020
@plessbd plessbd added Category:General General maintenance / code quality Improvements and code cleanup. Not a new feature or enhancement to existing functionality. labels Aug 21, 2020
@plessbd plessbd changed the title Generate png and pdf from svg Export of png and pdf now generated from the same svg Aug 21, 2020
@plessbd plessbd changed the title Export of png and pdf now generated from the same svg Export of png and pdf now generated from the same svg with similar metadata Aug 21, 2020
@plessbd plessbd changed the title Export of png and pdf now generated from the same svg with similar metadata Export of png and pdf now generated from the same svg both containing the "same" metadata Aug 21, 2020
@plessbd plessbd changed the title Export of png and pdf now generated from the same svg both containing the "same" metadata Add exif metadata to charts exported in png format. Aug 21, 2020
@plessbd plessbd added the autodoc:ignore Auto documentation ignore this PR label Aug 21, 2020
@plessbd plessbd changed the title Add exif metadata to charts exported in png format. Generate png and pdf from `svg Aug 21, 2020
@plessbd plessbd changed the title Generate png and pdf from `svg Generate png and pdf from svg Aug 21, 2020
@plessbd plessbd merged commit c479fc1 into ubccr:xdmod9.5 Aug 21, 2020
@plessbd plessbd deleted the more-charting-updates branch August 21, 2020 19:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
autodoc:ignore Auto documentation ignore this PR Category:General General maintenance / code quality Improvements and code cleanup. Not a new feature or enhancement to existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants