Removing Dependencies for Jaspersoft #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanrath
added
Category:Infrastructure
eiffel777
approved these changes
Feb 16, 2021
jpwhite4
pushed a commit
to jpwhite4/xdmod
that referenced
this pull request
Feb 23, 2021
Co-authored-by: Ryan Rathsam <build@shippable.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jaspersoft was replaced with PHPWord / LibreOffice in #1341 . This PR just removes composer dependencies & the script that handled making sure that these dependencies stuck around after fresh installs & upgrades
composer.scripts.php.Motivation and Context
In the process of confirming that we had addressed all of TrustedCI's findings, one of which was that we were using an old / vulnerable version of jaspersoft, I realized that while jaspersoft had been replaced it's dependencies were still present.
Tests performed
All automated tests for both a fresh install & upgrade.
Checklist: