Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added npm lock files #150

Merged
merged 1 commit into from
Jun 7, 2017
Merged

Added npm lock files #150

merged 1 commit into from
Jun 7, 2017

Conversation

tyearke
Copy link
Contributor

@tyearke tyearke commented Jun 2, 2017

Description

This pull request adds the lock files generated by npm v5 to this repo. This will lock down the npm dependencies in a manner similar to how Composer locks dependencies.

It also updates a Travis setup script to ensure npm is up to date.

If approved, similar pull requests will be opened for other XDMoD repos.

Motivation and Context

npm v5 automatically generates package-lock.json files similar to how Composer generates composer.lock files. Like the latter's lock files, they are designed to ensure that consistent environments are generated across instances and are intended to be checked into source control.

Tests Performed

I verified that tools pulled in by npm continue to work, and I verified that the changes to the Travis script work as intended.

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tyearke tyearke added the qa label Jun 2, 2017
@tyearke tyearke added this to the v7.0.0 milestone Jun 2, 2017
@tyearke tyearke merged commit 386350e into ubccr:xdmod7.0 Jun 7, 2017
@tyearke tyearke deleted the qa/npm-lock branch June 7, 2017 17:30
@plessbd plessbd added the qa / testing Updates/additions to tests label Mar 26, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
qa / testing Updates/additions to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants