Improve input validation for download_report controller #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The download_report controller endpoint already checks that the filename is acceptable. However, in the case of an invalid filename it potentially would try to open a file called [TMPDIR]/.[SUFFIX]. This change add an explicit exit if an invalid filename is supplied. Also add a test for this scenario and to check some of the other input validation code.
If a default is not supplied then the validator returns false if validation fails. The isValidFormat() function expects a string and this leads to a warning if false is supplied (although the isValidFormat correctly returns). This change updates the default to be an empty string which is not a valid format, but is the coreect data type for the isValidFormat() function.
hltaylor26
approved these changes
Mar 5, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The download_report controller endpoint already checks that the
filename is acceptable. However, in the case of an invalid filename
it potentially would try to open a file called [TMPDIR]/.[SUFFIX].
This change add an explicit exit if an invalid filename is supplied.
Also add a test for this scenario and to check some of the other input
validation code.