Allow multiple columns in RegexTransformIngestor.
#1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronweeden
added
the
enhancement
aaronweeden
force-pushed
the
allow-multiple-regex-transforms
branch
2 times, most recently
from
7b2d0bf to
23bdcc5
Compare
aaronweeden
added
the
Open OnDemand
aaronweeden
force-pushed
the
allow-multiple-regex-transforms
branch
from
23bdcc5 to
75f094e
Compare
jpwhite4
reviewed
May 13, 2024
aaronweeden
force-pushed
the
allow-multiple-regex-transforms
branch
3 times, most recently
from
37cb1bf to
f65d4ef
Compare
aaronweeden
changed the title
RegexTransformIngestor.RegexTransformIngestor.
aaronweeden
force-pushed
the
allow-multiple-regex-transforms
branch
7 times, most recently
from
b4b61c9 to
f604ab9
Compare
jpwhite4
requested changes
May 16, 2024
aaronweeden
force-pushed
the
allow-multiple-regex-transforms
branch
4 times, most recently
from
b68dbdf to
27fac1f
Compare
jpwhite4
approved these changes
May 29, 2024
aaronweeden
force-pushed
the
allow-multiple-regex-transforms
branch
from
27fac1f to
7bdfdcf
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR should not be merged unless ubccr/xdmod-ondemand#50 is also merged; otherwise
xdmod-ondemandingestion will break.Description
This PR allows the
RegexTransformIngestorto transform multiple columns.Motivation and Context
This enables ubccr/xdmod-ondemand#50, specifically the ability to transform
app,request_path,reverse_proxy_host, andreverse_proxy_portin the same pipeline action (ondemand.log-ingestion.normalize-staging).Tests performed
I tested ingesting logs on my port on
xdmod-devwith the changes from ubccr/xdmod-ondemand#50 and the PRs on which it depends.Checklist: