Update log table sql migration query to be more efficient #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiffel777
added
the
enhancement
eiffel777
requested review from
jpwhite4,
ryanrath,
aaronweeden,
connersaeli and
aestoltm
ryanrath
approved these changes
Jul 29, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This query can take a very, very long time when the
mod_logger.log_tableis large, changing to use aONcondition decreases the time the query takes to run from days in some cases to minutes.Tests performed
Tested on staging servers where query went from taking days to taking under a minute to run.
Checklist: