-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add ability to assign an organization to a resource #2007
Open
eiffel777
wants to merge
17
commits into
ubccr:main
Choose a base branch
from
eiffel777:add-organizations-to-resource
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/xdmod into add-organizations-to-resource
…realm, adding resource organization to raw statistics and updating migration
jpwhite4
reviewed
Apr 7, 2025
configuration/etl/etl_sql.d/migration/update_storage_resource_organization.sql
Outdated
Show resolved
Hide resolved
jpwhite4
requested changes
Apr 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good apart from the sonarcloud warning - I added a suggestion to add the where condition to the sql update statement
…organization.sql Co-authored-by: Joe White <jpwhite4@buffalo.edu>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to assign an organization to a resource. The following things have been added in this PR.
esource.json
. For the config file migration ofresources.json
, use the organization in theorganization.json
file.xdmod-setup
Tests performed
Tested in docker and upgraded and added new tests
Checklist: